Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack 5.2.1 breaks TinyMCE editors in Leaflet Maps Marker & Maps Marker Pro #7600

Closed
seyfro opened this issue Aug 5, 2017 · 3 comments
Closed
Assignees
Labels
[Feature] Contact Form [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended

Comments

@seyfro
Copy link

seyfro commented Aug 5, 2017

Hi,

I am the developer of the mapping plugins Leaflet Maps Marker and Maps Marker Pro.

Users reported a plugin conflict with the latest Jetpack 5.2.1: our plugins add a tinyMCE editor to marker edit pages and if Jetpack 5.2.1 is active, the visual editor breaks with the following error in the browser console: ReferenceError: grunionEditorView is not defined – caused by tinymce-plugin-form-button.js:7:5

It seems other plugin developers are having the same issue too, see https://wordpress.org/support/topic/5-2-breaks-text-and-tinymce-widgets/#post-9379121 for example where also a possible solution is posted:

So a quick fix would be to remove that snippet (which would force the javascript stuff to be loaded on all the admin pages).
A more robust fix would be to add the widget.php screen to the conditions that trigger the inclusion of the scripts, and/or provide a filter hook to allow other devs to change that behavior based on custom conditions.

A quick fix/new bugfix release would be much appreciated!

@seedprod
Copy link

seedprod commented Aug 5, 2017

Yep seeing the same in error in my plugin, or anything that uses wp_editor

@kraftbj kraftbj added [Feature] Contact Form [Pri] BLOCKER [Status] Needs Patch [Type] Bug When a feature is broken and / or not performing as intended labels Aug 6, 2017
@kraftbj
Copy link
Contributor

kraftbj commented Aug 6, 2017

@georgestephanis

@nylen
Copy link
Contributor

nylen commented Aug 7, 2017

Yep, this is a duplicate of #7598.

@nylen nylen closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants