Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo Gardening: handle External Media extension #40408

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Dec 2, 2024

Proposed changes:

This should allow automatically labeling PRs like #40382

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

No

Does this pull request change what data or activity we track or use?

No

Testing instructions:

This can be tested in a fork, by merging this branch to trunk and then opening a PR making changes to a file like projects/plugins/jetpack/extensions/shared/external-media/media-button/media-ai-button.js.

This should allow automatically labeling PRs like #40382
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial [Pri] Normal [Extension] External Media Extend all block editor media tools to support external providers labels Dec 2, 2024
@jeherve jeherve requested a review from a team December 2, 2024 10:52
@jeherve jeherve self-assigned this Dec 2, 2024
@github-actions github-actions bot added [Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

const externalMedia = file.match(
/^projects\/plugins\/jetpack\/extensions\/shared\/external-media\//
);
if ( externalMedia !== null ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker (and I see it's done like this elsewhere), but I prefer simplifying the construct:

Suggested change
if ( externalMedia !== null ) {
if ( externalMedia ) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see about updating them all at once in a future PR!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, as this works as described.

More generally I do wonder if we have a label bloat problem; do we really need such specific labels?

@jeherve
Copy link
Member Author

jeherve commented Dec 2, 2024

More generally I do wonder if we have a label bloat problem; do we really need such specific labels?

That's a good question. They do prove useful for stats, reporting, and for the automations (like pinging in Slack or adding to project boards) so they are useful, but I do think that for some of our products, they're not useful (i.e. the "[Feature] Photon" and "[Package] Image CDN" could probably be merged into one if we updated our logic).

I'll see about starting a discussion about this. 👍

@jeherve jeherve merged commit fc4c584 into trunk Dec 2, 2024
57 checks passed
@jeherve jeherve deleted the update/repo-gardening-label-external-meida branch December 2, 2024 15:23
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Action] Repo Gardening Github Action: manage PR and issues in your Open Source project Actions GitHub actions used to automate some of the work around releases and repository management [Extension] External Media Extend all block editor media tools to support external providers [Pri] Normal [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants