-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repo Gardening: handle External Media extension #40408
Conversation
This should allow automatically labeling PRs like #40382
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
const externalMedia = file.match( | ||
/^projects\/plugins\/jetpack\/extensions\/shared\/external-media\// | ||
); | ||
if ( externalMedia !== null ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker (and I see it's done like this elsewhere), but I prefer simplifying the construct:
if ( externalMedia !== null ) { | |
if ( externalMedia ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll see about updating them all at once in a future PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, as this works as described.
More generally I do wonder if we have a label bloat problem; do we really need such specific labels?
That's a good question. They do prove useful for stats, reporting, and for the automations (like pinging in Slack or adding to project boards) so they are useful, but I do think that for some of our products, they're not useful (i.e. the "[Feature] Photon" and "[Package] Image CDN" could probably be merged into one if we updated our logic). I'll see about starting a discussion about this. 👍 |
Proposed changes:
This should allow automatically labeling PRs like #40382
Other information:
Jetpack product discussion
No
Does this pull request change what data or activity we track or use?
No
Testing instructions:
This can be tested in a fork, by merging this branch to
trunk
and then opening a PR making changes to a file likeprojects/plugins/jetpack/extensions/shared/external-media/media-button/media-ai-button.js
.