Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments / Subscriptions: change default cookie expiration from 30000000 to YEAR_IN_SECONDS #38027

Open
Tracked by #36721
jeherve opened this issue Jun 25, 2024 · 0 comments
Open
Tracked by #36721

Comments / Subscriptions: change default cookie expiration from 30000000 to YEAR_IN_SECONDS #38027

jeherve opened this issue Jun 25, 2024 · 0 comments
Labels
[Feature] Comments [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Low [Type] Good First Bug [Type] Janitorial

Comments

@jeherve
Copy link
Member

jeherve commented Jun 25, 2024

Let's ensure our implementation matches recent changes in Core:

jetpack/projects/plugins/jetpack/modules/subscriptions.php

Line 890 in a078855

$cookie_lifetime = apply_filters( 'comment_cookie_lifetime', 30000000 );

jetpack/projects/plugins/jetpack/modules/comments/base.php

Line 306 in 1089648

$comment_cookie_lifetime = apply_filters( 'comment_cookie_lifetime', 30000000 );

https://core.trac.wordpress.org/changeset/58401
@jeherve jeherve added [Feature] Comments [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Type] Janitorial [Pri] Low labels Jun 25, 2024
@jeherve jeherve mentioned this issue Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Comments [Feature] Subscriptions All subscription-related things such as paid and unpaid, user management, and newsletter settings. [Pri] Low [Type] Good First Bug [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simison @jeherve