Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin configuration: missing redirect on activation #36844

Closed
Tracked by #36721
jeherve opened this issue Apr 11, 2024 · 6 comments
Closed
Tracked by #36721

Plugin configuration: missing redirect on activation #36844

jeherve opened this issue Apr 11, 2024 · 6 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" General [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Reach (Deprecated, this plugin is now called Social) [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Apr 11, 2024

A lot of our plugins rely on the activated_plugin hook to redirect the site owner to a configuration screen upon activation. Unfortunately, that is no longer an option starting in WordPress 6.5. We may have to adjust our flows accordingly, if that core change is not adjusted.

Related Core ticket:

https://core.trac.wordpress.org/ticket/60992

Internal report:

  • p1HpG7-rYC-p2#comment-71125
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended General [Pri] Normal [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Reach (Deprecated, this plugin is now called Social) [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Automattic For Agencies Client labels Apr 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • p1HpG7-rYC-p2#comment-71125

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Apr 11, 2024
@cat-og
Copy link

cat-og commented Apr 12, 2024

I tested this on my sites; version 6.5.2. I wasn't able to replicate the issue, can you provide an example of some of the plugins affected?

@cat-og cat-og moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Apr 12, 2024
@jeherve
Copy link
Member Author

jeherve commented Apr 12, 2024

@cat-og Yes, see the labels added to this issue. You can also see the video in the internal reference attached for an example.

@jeherve jeherve moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Apr 23, 2024
@jeherve
Copy link
Member Author

jeherve commented May 10, 2024

A workaround was implemented and released with WordPress 6.5.3.

@jeherve jeherve closed this as completed May 10, 2024
@jeherve jeherve mentioned this issue May 10, 2024
Closed
@jeherve
Copy link
Member Author

jeherve commented May 28, 2024

Reopening this, since we'll need to make changes following the new filter that may be introduced here:
https://core.trac.wordpress.org/ticket/61269

@jeherve jeherve reopened this May 28, 2024
@jeherve
Copy link
Member Author

jeherve commented Jun 5, 2024

Closing this for now since the new filter is not happening yet, and the redirect was reverted in WordPress 6.5.4.

Any upcoming changes to plugin onboarding (tracked here) can be discussed in another issue.

@jeherve jeherve closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" General [Plugin] Automattic For Agencies Client [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Reach (Deprecated, this plugin is now called Social) [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeherve @cat-og