-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with Google Fonts persistence after Jetpack deactivation in WordPress 6.5 (RC2) #36371
Comments
Thanks for the report! Could you let me know what version of Jetpack is currently installed on your site, or was installed before you deactivated it? cc @arthur791004 who recently worked on #35986. |
I've tested with the latest version 13.2.1. |
@jeherve I noticed this issue today on a website that's running WordPress 6.7.1 and Jetpack 14.0. I've disabled the Google Fonts (Beta) module in Jetpack, but I have about 700 lines of Google Fonts on the front end of my website. I'm also still able to select all of the Google Fonts under "Typography". |
@ChrisBegley Thanks for the report. I assume you've already tried to flush your site's cache, and that didn't help? Does the problem remain when you switch themes, too? |
@jeherve yes, flushing the cache didn't help. But switching themes did, thank you. I'm using the Ollie theme: https://wordpress.org/themes/ollie/ I'm using the Ollie theme on another website that doesn't have this issue though. I'll keep troubleshooting. |
What happens when you switch back to your old theme? Do the fonts come back? |
Yes, they do. And I have the full list of Google fonts available in Appearance > Styles > Typography, even though the Google Fonts module in Jetpack is deactivated. |
@Automattic/lego Is that something you could look at? Thank you! |
Thanks for the ping, I've moved the task to Up Next so that it can be picked up in our maintenance process |
Here are things the google fonts module does
As a result, it will still be there and all google fonts will be printed on the frontend after the deactivation. I'll propose a PR to clean up the Google Fonts data in the global styles after the deactivation so the issue will be fixed after the activation and then deactivation again. However, the global styles are based on the active theme so the issue might happen again after the theme switch. If it happens, you have to re-deactivate again. |
I've tested on the newly created site but I couldn't reproduce the issue. I guess it's related to #34306 and somehow the default global styles might be saved into the user global styles |
@ChrisBegley Since I couldn't reproduce the issue on my sites, it would be helpful if you could help us to check data as follows:
Thank you! |
@arthur791004 thanks for looking into this! I'm not familiar with that SSH process, but I did look up the information you requested in the database. I think I see the problem...
On another website, with the same theme that doesn't have this issue, I do see it. The |
@arthur791004 nevermind, I found it! Here's what's in
|
Thanks! It's super useful! |
@arthur791004 you're welcome! Not sure if this was the best way for me to fix it on my end, but I copied my custom CSS, made a note of all my style changes, and then deleted the |
@ChrisBegley Yes, this resolves the issue! The reason behind it is that the Google Fonts data might have been stored in your global styles, which caused the fonts to remain even after deactivating the module. By resetting the global styles, the issue was fixed. What I suggest is cleaning up this data when you deactivate either the module or the Jetpack plugin. |
Impacted plugin
Jetpack
Quick summary
In WordPress 6.5 (RC2), after making changes in the Font Library, deactivating the Jetpack Google Fonts module or the entire Jetpack plugin results in all previously added Google Fonts being permanently printed (more than 600 lines) on the website's front-end. This happens without providing users an option to remove these fonts.
Steps to reproduce
A clear and concise description of what you expected to happen.
No response
What actually happened
Jetpack adds its Google Fonts using the
wp_theme_json_data_default
hook, which means the fonts cannot be managed or removed through the Font Library. #33203Impact
All
Available workarounds?
No but the platform is still usable
Platform (Simple and/or Atomic)
No response
Logs or notes
No response
The text was updated successfully, but these errors were encountered: