VideoPress block: Some settings are lost after replacing video

[SiobhyB]

Impacted plugin

VideoPress

Quick summary

When you replace a video in a block some of the block's saved settings are not retained, while some are not.

Steps to reproduce

1. Navigate to a post with an existing VideoPress block.
2. Open the block's settings panel and make changes to all of the settings within the block.
3. Save the post.
4. Select the block again and click the Replace button.
5. Upload a new video from your device.
6. Verify what the settings are for the block.

A clear and concise description of what you expected to happen.

I would expect for either all of the block's setting to be retained or for all of the them to be 'reset' following the replacement. As other media block's generally retain settings when there's a replacement, I would lean more towards settings being retained as an expectation.

What actually happened

The only settings that are not retained at the block's description and any changes made under the Privacy and Ratings panel. Change to the title and playback settings are retained.

replace.mov

A proposal to retain all settings in the app has been made in #30229, but it is on hold so that we can align with the web's handling of this. If we decide that all settings should be retained following a replacement, please ping me on that PR so that both the web and the app align on this.

Impact

One

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

[cuemarie]

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

• Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
Tested in an AT WPcom site, and here's what reset and what did not in the block settings:

• Details
  • TITLE - ❌ did not reset, but I was given a field to update the title during the new video's upload time
  • DESCRIPTION - 🔄 reset to default
• Playback - ❌ nothing in this section reset - all my settings from before the replacement were retained
• Poster - 🔄 reset to default
• Privacy and rating - 🔄 reset to default

Screenshots/Recordings

Settings before replacing video:

X3IabE.mp4

Settings after replacing video:

Screen.Capture.on.2023-04-20.at.16-30-25.mp4

📌 ACTIONS

• Assigned to Other

[github-actions]

This issue has been marked as stale. This happened because:

• It has been inactive for the past 6 months.
• It hasn’t been labeled `[Pri] BLOCKER`, `[Pri] High`, `[Type] Feature Request`, `[Type] Enhancement`, `[Type] Janitorial`, `Good For Community`, `[Type] Good First Bug`, etc.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.