-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress, Video block: Auto-play and loop share options not working #21737
Comments
This issue has been marked as stale and will be closed in seven days. This happened because:
You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation. |
Unfortunately it won't always work. As we discovered when we first introduced the feature to the block settings in #13134, some browsers can prevent a video from being autoplayed. You can read more about this in this comment, where we discovered that browsers would not respect autoplay in some scenarios (like the video not being muted), while others would never respect it: |
35760045-hc a customer asked why autoplay wasn't working. It also didn't work for me in 5 different browsers using my test site. (I tested Chrome, Safari, Firefox, Edge, and Brave.) If this feature doesn't work for close to 99% of browsers, shouldn't it be removed? |
That's a valid question, and maybe something worth considering. @Automattic/greenhouse What's your take on this? |
It would probably be helpful if we documented this somewhere on the block settings though OR if we just automatically muted a video when |
We've deployed a change that forces the video to be muted when autoplay is enabled. |
@jgcaruso Thanks for this change. I encountered one customer where they had the Autoplay feature enabled, and the video did not autoplay, muted or unmuted. However, I was not able to reproduce this behavior on my test sites. I noticed that when the Autoplay setting is enabled, the Muted setting does not visually enable. I suggest as an improvement that it would be beneficial to force the Muted setting to visually enable, so this way the user understands that Autoplay will cause the video to be muted. As well, I suggest replacing the text below the "Autoplay" setting. Currently it says this:
Perhaps that text could be replaced or augmented with something along these lines:
|
Support References This comment is automatically generated. Please do not edit it.
|
There was this change back in August that actually allows autoplay to play with audio if the browser allows it. The viewing user can give the browser permission to do this for certain sites. So we don't want to force muted on autoplay videos since it would break that functionality. https://github.com/Automattic/greenhouse/issues/1274#issuecomment-1222735389 There is a card though to give the editor more control over if that feature should be supported, but no eta on when that will be addressed https://github.com/Automattic/videopress/issues/1066 |
Steps to reproduce
What I expected
I expected the video to autoplay and loop when the page loads.
What happened instead
The video doesn't autoplay or loop when the page loads. Also when I refreshed the page in the editor and clicked the "Share" button at the top right again, I noticed the checkboxes have been unchecked. Like the changes didn't save. However, when I manually added autoplay=true and loop=true to the video shortcode, the video is able to autoplay and loop as expected.
Browser / OS version
Chrome / Windows 10
Screenshot / Video
Context / Source
The text was updated successfully, but these errors were encountered: