Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress, Video block: Auto-play and loop share options not working #21737

Open
sbassah opened this issue Jun 2, 2018 · 10 comments
Open

VideoPress, Video block: Auto-play and loop share options not working #21737

sbassah opened this issue Jun 2, 2018 · 10 comments
Labels
[Block] VideoPress Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sbassah
Copy link

sbassah commented Jun 2, 2018

Steps to reproduce

  1. Go to https://wordpress.com/ > My Sites > Pages > Add Page.
  2. Click the Add button to add a video to the text editor
  3. Upload / Select a video and click Insert to insert the video into the text editor
  4. Click the "Share" button at the top right
  5. Check the checkboxes for Autoplay and Loop
  6. Publish Page.

What I expected

I expected the video to autoplay and loop when the page loads.

What happened instead

The video doesn't autoplay or loop when the page loads. Also when I refreshed the page in the editor and clicked the "Share" button at the top right again, I noticed the checkboxes have been unchecked. Like the changes didn't save. However, when I manually added autoplay=true and loop=true to the video shortcode, the video is able to autoplay and loop as expected.

Browser / OS version

Chrome / Windows 10

Screenshot / Video

videop1

Context / Source

@stale
Copy link

stale bot commented Mar 1, 2019

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot closed this as completed Mar 8, 2019
@formosattic
Copy link

formosattic commented Nov 14, 2021

Issue still there, autoplay set in the Video block doesn't work.
User report (4453768-zd-woothemes), but also reproduced on self-hosted site so moving this to Jetpack.

image1

@formosattic formosattic reopened this Nov 14, 2021
@formosattic formosattic changed the title VideoPress: Auto-play and loop share options not working VideoPress, Video block: Auto-play and loop share options not working Nov 14, 2021
@formosattic formosattic transferred this issue from Automattic/wp-calypso Nov 14, 2021
@formosattic formosattic added [Block] VideoPress [Feature] VideoPress A feature to help you upload and insert videos on your site. [Type] Bug When a feature is broken and / or not performing as intended labels Nov 14, 2021
@jeherve
Copy link
Member

jeherve commented Nov 15, 2021

autoplay set in the Video block doesn't work.

Unfortunately it won't always work. As we discovered when we first introduced the feature to the block settings in #13134, some browsers can prevent a video from being autoplayed. You can read more about this in this comment, where we discovered that browsers would not respect autoplay in some scenarios (like the video not being muted), while others would never respect it:
#13134 (comment)

@jeherve jeherve closed this as completed Nov 15, 2021
@jeherve jeherve added the [Closed] Won't Fix wontfix. This issue will not be addressed. label Nov 15, 2021
@masperber
Copy link
Contributor

35760045-hc a customer asked why autoplay wasn't working. It also didn't work for me in 5 different browsers using my test site. (I tested Chrome, Safari, Firefox, Edge, and Brave.)

If this feature doesn't work for close to 99% of browsers, shouldn't it be removed?

@masperber masperber reopened this Jun 9, 2022
@jeherve
Copy link
Member

jeherve commented Jun 10, 2022

If this feature doesn't work for close to 99% of browsers, shouldn't it be removed?

That's a valid question, and maybe something worth considering.

@Automattic/greenhouse What's your take on this?

@jeherve jeherve removed the [Closed] Won't Fix wontfix. This issue will not be addressed. label Jun 10, 2022
@jgcaruso
Copy link
Contributor

autoplay has a catch where if the video has audio then you also need to mark the video as muted. Doing that should work 100% of the time, regardless of the browser. This is a browser restriction for all web video, and not something specific to VideoPress. The only other catch would be if you are on a mobile device you may also need plays inline to be enabled.

It would probably be helpful if we documented this somewhere on the block settings though OR if we just automatically muted a video when autoplay is enabled. I'll add a card to our team board to take a look at this.

@jgcaruso
Copy link
Contributor

We've deployed a change that forces the video to be muted when autoplay is enabled.

@masperber
Copy link
Contributor

@jgcaruso Thanks for this change. I encountered one customer where they had the Autoplay feature enabled, and the video did not autoplay, muted or unmuted. However, I was not able to reproduce this behavior on my test sites.

I noticed that when the Autoplay setting is enabled, the Muted setting does not visually enable. I suggest as an improvement that it would be beneficial to force the Muted setting to visually enable, so this way the user understands that Autoplay will cause the video to be muted.

As well, I suggest replacing the text below the "Autoplay" setting.

Currently it says this:

Autoplay may cause usability issues for some users.

Perhaps that text could be replaced or augmented with something along these lines:

Autoplay may only be enabled when Muted is enabled.

@github-actions
Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 4453768-zen

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label May 14, 2023
@jgcaruso
Copy link
Contributor

I noticed that when the Autoplay setting is enabled, the Muted setting does not visually enable.

There was this change back in August that actually allows autoplay to play with audio if the browser allows it. The viewing user can give the browser permission to do this for certain sites. So we don't want to force muted on autoplay videos since it would break that functionality.

https://github.com/Automattic/greenhouse/issues/1274#issuecomment-1222735389

There is a card though to give the editor more control over if that feature should be supported, but no eta on when that will be addressed https://github.com/Automattic/videopress/issues/1066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] VideoPress Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] VideoPress A feature to help you upload and insert videos on your site. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

6 participants