Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: switch away from __experimentalBlock to useBlockProps #18864

Closed
2 tasks done
jeherve opened this issue Feb 17, 2021 · 6 comments · Fixed by #19913
Closed
2 tasks done

Blocks: switch away from __experimentalBlock to useBlockProps #18864

jeherve opened this issue Feb 17, 2021 · 6 comments · Fixed by #19913
Assignees
@apeatling @jgcaruso
Labels
[Block] Paid Content aka Premium Content [Block] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial
Milestone
jetpack/9.9

Comments

@jeherve
Copy link
Member

jeherve commented Feb 17, 2021 •
edited
Loading

WordPress 5.6 (soon to be required to use the Jetpack plugin) introduces the following change:
https://make.wordpress.org/core/2020/11/18/block-api-version-2/

It will allow us to switch away from __experimentalBlock to useBlockProps for some of our blocks.

Matching Gutenberg change:
WordPress/gutenberg#31419

Primary issues: #18842 (5.7), #19654 (5.8)
@jeherve jeherve added [Type] Janitorial [Pri] Normal [Block] Paid Content aka Premium Content [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Block] VideoPress labels Feb 17, 2021
@jeherve jeherve mentioned this issue Feb 17, 2021
Closed
11 tasks
@jeherve jeherve added this to the jetpack/9.9 milestone May 12, 2021
@jeherve jeherve mentioned this issue May 12, 2021
Closed
20 tasks
@WunderBart WunderBart mentioned this issue May 12, 2021
Closed
37 tasks
@andrewserong
Copy link
Member

@jeherve just double checking, it looks like WordPress 5.6 is the required minimum version of WordPress for the Jetpack plugin. I assume this means we can move over to using useBlockProps directly without having to guard it behind a check / maintain the existing __experimentalBlock for backwards compatibility?

@jeherve
Copy link
Member Author

jeherve commented May 13, 2021

@andrewserong Yes, correct. In addition to that, we can aim to have this issue closed by the time WordPress 5.8 is available (Jetpack 9.9); by then, Jetpack will require WP 5.7.

@andrewserong
Copy link
Member

Great, thanks for confirming!

@apeatling apeatling mentioned this issue May 13, 2021
Merged
@jeherve jeherve mentioned this issue May 19, 2021
Closed
@roundhill
Copy link
Contributor

@jeherve has anyone on Jetpack taken on the Video block changes? If not we'll handle it 😄

@jeherve
Copy link
Member Author

jeherve commented May 19, 2021

Noone has looked at it yet, no. I'll be happy if you do :)

@jgcaruso jgcaruso mentioned this issue May 21, 2021
Merged
@roundhill
Copy link
Contributor

Video block is ready for review: #19913

@fullofcaffeine fullofcaffeine mentioned this issue May 25, 2021
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apeatling apeatling

@jgcaruso jgcaruso

Labels
[Block] Paid Content aka Premium Content [Block] VideoPress [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Janitorial
Projects
None yet
Milestone
jetpack/9.9
Development

Successfully merging a pull request may close this issue.

Update VideoPress block for useBlockProps Automattic/jetpack
6 participants
@kraftbj @jeherve @roundhill @apeatling @jgcaruso @andrewserong