Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revue: issue with deprecated blocks #15629

Closed
jeherve opened this issue Apr 30, 2020 · 0 comments · Fixed by #15633
Closed

Revue: issue with deprecated blocks #15629

jeherve opened this issue Apr 30, 2020 · 0 comments · Fixed by #15633
Assignees
@Copons
Labels
[Block] Revue [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.5

Comments

@jeherve
Copy link
Member

jeherve commented Apr 30, 2020

This seems to be caused by #15370.

The markup for the deprecated version of the block doesn't have a form, so we can't find that form here:

jetpack/extensions/blocks/revue/view.js

Line 16 in c70ed04

const form = block.querySelector( '.wp-block-jetpack-revue__form' );

It causes a JS error on the frontend:

Uncaught TypeError: Cannot read property 'addEventListener' of null
    at view.js:formatted:91

Reported here:
p8oabR-uL-p2#comment-4175
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] High [Block] Revue labels Apr 30, 2020
@jeherve jeherve added this to the 8.5 milestone Apr 30, 2020
@Copons Copons mentioned this issue Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Copons Copons

Labels
[Block] Revue [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.5
Development

Successfully merging a pull request may close this issue.

Revue Block: Avoid JS Error in the Front End Automattic/jetpack
2 participants
@jeherve @Copons