Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Block: migration degrades performance #15449

Open
obenland opened this issue Apr 14, 2020 · 1 comment
Open

Subscription Block: migration degrades performance #15449

obenland opened this issue Apr 14, 2020 · 1 comment
Labels
[Block] Subscriptions [Pri] Normal [Size] M [Type] Bug When a feature is broken and / or not performing as intended

Comments

@obenland
Copy link
Member

Working on Automattic/wp-calypso#40658 I noticed that the subscription block gets updated every time the page template selector gets loaded. It turns out the block gets run through the migration process every time it's loaded, regardless of whether the markup is current or not.

It looks like input and output are the same though, leading to an unnecessary performance degradation where the selector can't finish loading until every subscription block has been updated.

Steps to reproduce the issue

  1. Go to https://wordpress.com/block-editor/page and select your test site.
  2. Open your console in developer toolbar and find block update messages from subscription block

Screenshots

image

@obenland obenland added [Type] Bug When a feature is broken and / or not performing as intended [Block] Subscriptions labels Apr 14, 2020
@apeatling apeatling changed the title Suscription: Block migration degrades performance Subscription Block: migration degrades performance May 13, 2020
@apeatling
Copy link
Member

@obenland This also seems to be true of core blocks from what I'm seeing in the console?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Subscriptions [Pri] Normal [Size] M [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

3 participants