Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Search: load more results on scroll #14406

Closed
bluefuton opened this issue Jan 20, 2020 · 3 comments
Closed

Instant Search: load more results on scroll #14406

bluefuton opened this issue Jan 20, 2020 · 3 comments
Labels
[Feature] Search For all things related to Search [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@bluefuton
Copy link
Contributor

bluefuton commented Jan 20, 2020 •
edited
Loading

We currently handle paging by displaying a 'load more...' button. It'd be better if more results appeared magically on scroll instead.

@jeherve suggested in #13761 (review):

It would be nice if the infinite loader used a similar style to the one used for Infinite Scroll module, to keep things consistent.
@bluefuton bluefuton added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Search For all things related to Search Instant Search labels Jan 20, 2020
@bluefuton bluefuton added this to the InstantSearchLater milestone Jan 20, 2020
@bluefuton bluefuton mentioned this issue Jan 20, 2020
Closed
13 tasks
@gibrown
Copy link
Member

gibrown commented Jan 22, 2020

I'm not sure if the style is an issue anymore give that we now have an overlay, but we do need to hook up infinite scroll to work.

@bluefuton bluefuton changed the title Instant Search: make infinite scroll consistent with existing Jetpack Infinite Scroll module Instant Search: load more results on scroll Jan 22, 2020
@bluefuton
Copy link
Contributor Author

I'm not sure if the style is an issue anymore give that we now have an overlay, but we do need to hook up infinite scroll to work.

Sounds good 👍 I've updated the title and description.

@jsnmoon jsnmoon removed this from the InstantSearchLater milestone Jul 14, 2020
@jsnmoon
Copy link
Contributor

jsnmoon commented Jul 14, 2020

Infinite scroll has been implemented in Instant Search.

@jsnmoon jsnmoon closed this as completed Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Search For all things related to Search [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bluefuton @gibrown @jsnmoon