Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instant Search: leaving post_types URL parameter empty should not restrict results #13872

Closed
bluefuton opened this issue Oct 29, 2019 · 1 comment
Closed

Instant Search: leaving post_types URL parameter empty should not restrict results #13872

bluefuton opened this issue Oct 29, 2019 · 1 comment
Assignees
@jsnmoon
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended

Comments

@bluefuton
Copy link
Contributor

Steps to reproduce the issue

  1. Follow instructions in Instant Search: Update prototype with downstream changes #13761 to get search running
  2. Try entering a search URL with a blank post_types parameter like /?s=yes&blog_id=20115252&post_types=

What I expected

An empty post types parameter should not have any impact on the final results.

post_types=

What happened instead

It eliminates all results that don't match the specified post types (and there aren't any).
@bluefuton bluefuton added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search Instant Search labels Oct 29, 2019
@jsnmoon jsnmoon self-assigned this Nov 1, 2019
@jsnmoon jsnmoon mentioned this issue Nov 1, 2019
Merged
@bluefuton
Copy link
Contributor Author

Fixed in #13934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnmoon jsnmoon

Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluefuton @jsnmoon