-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoPress: Revisit block extension behavior #12358
Comments
@lessbloat @cathymcbride I'm adding this one to the Manage backlog for increased visibility. This is a long standing issue and has to do with how the VideoPress block was implemented to override the Core video block markup. I see at least one related user report. Related Gutenberg Mobile issue: (Videos added/edited on the web don't load in mobile editor I can replicate the problem by following the instructions in that issue. |
More background discussion: pafL3P-pg-p2 |
Hello 👋! Is there any progress or maybe new understanding or plan for this ticket on the Jetpack side of things? Thanks! |
I'm not sure there has been any movement on this. @jeherve, do you? |
I don't believe the Video block is on anyone's radar at the moment; it's still in the Manage backlog as you can see on the project boards. |
Closing as this was addressed with the recent improvements made to the VideoPress block. |
Currently, the VideoPress extension for the block editor extends the
core/video
block in order to use the VideoPress player in both the editor and the published view if the video has been transcoded by VideoPress.Since we're saving a different block output into the post content from whats
core/video
saves, we could lead to failures when the block markup is validated:We should revisit the current approach, since this might not result in a great experience. One option is to change the block output server-side only and leave the
core/video
block unaltered. Another approach is to deactivatecore/video
and register a new block so we avoid conflicts.Unfortunately, we should keep maintaining the current behavior as a deprecated version of the
core/video
block in order to handle video blocks that have been created until the new approach is available.The text was updated successfully, but these errors were encountered: