Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: Revisit block extension behavior #12358

Closed
mmtr opened this issue May 14, 2019 · 6 comments
Closed

VideoPress: Revisit block extension behavior #12358

mmtr opened this issue May 14, 2019 · 6 comments
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Size] M [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@mmtr
Copy link
Member

mmtr commented May 14, 2019

Currently, the VideoPress extension for the block editor extends the core/video block in order to use the VideoPress player in both the editor and the published view if the video has been transcoded by VideoPress.

Since we're saving a different block output into the post content from whats core/video saves, we could lead to failures when the block markup is validated:

  • When Jetpack is deactivated.
  • On environments that can edit existing posts but where the Jetpack blocks are not loaded (i.e. WordPress mobile apps).

Screen Shot 2019-05-14 at 10 28 44

We should revisit the current approach, since this might not result in a great experience. One option is to change the block output server-side only and leave the core/video block unaltered. Another approach is to deactivate core/video and register a new block so we avoid conflicts.

Unfortunately, we should keep maintaining the current behavior as a deprecated version of the core/video block in order to handle video blocks that have been created until the new approach is available.

@mmtr mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] VideoPress A feature to help you upload and insert videos on your site. labels May 14, 2019
@jeherve jeherve added the [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack label May 14, 2019
@creativecoder
Copy link
Contributor

@lessbloat @cathymcbride I'm adding this one to the Manage backlog for increased visibility.

This is a long standing issue and has to do with how the VideoPress block was implemented to override the Core video block markup. I see at least one related user report.

Related Gutenberg Mobile issue: (Videos added/edited on the web don't load in mobile editor

I can replicate the problem by following the instructions in that issue.

@creativecoder
Copy link
Contributor

More background discussion: pafL3P-pg-p2

@hypest
Copy link
Contributor

hypest commented Dec 4, 2020

Hello 👋! Is there any progress or maybe new understanding or plan for this ticket on the Jetpack side of things? Thanks!

@cathymcbride
Copy link

I'm not sure there has been any movement on this. @jeherve, do you?

@jeherve
Copy link
Member

jeherve commented Dec 7, 2020

I don't believe the Video block is on anyone's radar at the moment; it's still in the Manage backlog as you can see on the project boards.

@jeherve
Copy link
Member

jeherve commented Feb 27, 2023

Closing as this was addressed with the recent improvements made to the VideoPress block.

@jeherve jeherve closed this as completed Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Size] M [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants