From 1c51ae421f8736242803e3ecc5f1b241328d8e1e Mon Sep 17 00:00:00 2001 From: Nick Daugherty Date: Tue, 4 Dec 2018 11:08:19 -0700 Subject: [PATCH 1/2] Always run integration tests The tests have been broken for a while but nobody has noticed b/c they aren't running in CI --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 3d5a0a62..74e92f62 100644 --- a/.travis.yml +++ b/.travis.yml @@ -24,7 +24,7 @@ script: - ./bin/unit-tests # Run integration test. - - if [[ "$INTEGRATION_TEST" == "1" ]]; then ./bin/integration-test; fi + - ./bin/integration-test # Rather than a `matrix` property, we use build stages. This allows early # build failure for basic linting and sniffing issues. From 114e769354d1190f8573ab42b29f38dedff7ac9e Mon Sep 17 00:00:00 2001 From: Nick Daugherty Date: Tue, 4 Dec 2018 11:20:09 -0700 Subject: [PATCH 2/2] Expect var_dump to trigger a warning, not an error Currently, all functions in `WordPress.PHP.DevelopmentFunctions` are warnings, not errors --- ruleset_test.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ruleset_test.php b/ruleset_test.php index 2971625b..1d394c0a 100644 --- a/ruleset_test.php +++ b/ruleset_test.php @@ -27,7 +27,6 @@ 24 => 1, 40 => 1, 43 => 1, - 45 => 1, 48 => 1, 49 => 1, 53 => 1, @@ -60,6 +59,7 @@ 28 => 1, 36 => 1, 44 => 1, + 45 => 1, 65 => 1, 70 => 1, 85 => 1, @@ -265,4 +265,3 @@ private function error_warning_message( $expected, $type, $number, $line ) { } else { exit( 1 ); } -