Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Undefined Variable Warning when Arguments are Passed to Templates #598

Closed
kopepasah opened this issue Dec 2, 2020 · 1 comment
Closed

Comments

@kopepasah
Copy link

What problem would the enhancement address for VIP?

Since WordPress 5.5, we are able to pass argument to a template: https://make.wordpress.org/core/2020/07/17/passing-arguments-to-template-files-in-wordpress-5-5/

However, when doing so the VIP coding standards flags this as an undefined variable.

VariableAnalysis.CodeAnalysis.VariableAnalysis.UndefinedVariable

Describe the solution you'd like

Pass arguments variable to templates without receiving a warning.

What code should be reported as a violation?

Any time the arguments are pass and not used, perhaps?

What code should not be reported as a violation?

Arguments passed as a variable to templates.

Additional context

Nothing at this time.

@jrfnl
Copy link
Collaborator

jrfnl commented Aug 26, 2023

Correct me if I'm wrong, but wasn't this addressed by adding the allowUndefinedVariablesInFileScope property in PR #690 (included in VIPCS 2.3.3) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants