Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WordPressVIPMinimum.Variables.VariableAnalysis #496

Closed
GaryJones opened this issue Jul 11, 2020 · 1 comment · Fixed by #776
Closed

Remove WordPressVIPMinimum.Variables.VariableAnalysis #496

GaryJones opened this issue Jul 11, 2020 · 1 comment · Fixed by #776
Labels
Milestone

Comments

@GaryJones
Copy link
Contributor

What problem would the enhancement address for VIP?

Since VIPCS 3.0 is a major release with breaking changes, we can remove the deprecated WordPressVIPMinimum.Variables.VariableAnalysis sniff completely.

Describe the solution you'd like

Remove the relevant sniff files, test files, ruleset test snippets and corresponding violation line references, and the ruleset XML references.

@GaryJones GaryJones added Type: Maintenance Require: VIPCS 3.0 Breaking changes for major version labels Jul 11, 2020
@GaryJones GaryJones added this to the 3.0 milestone Jul 11, 2020
@GaryJones
Copy link
Contributor Author

Per #612:

Action plan suggestion:

  • Deprecate the sniff in the next release (2.x) by:
    • Adding a deprecation warning to the sniff which will inform people to remove the sniff reference from their own custom ruleset.
    • Silencing all messages from the sniff from within the VIPMinimum ruleset, effectively removing the sniff already for people using the standard rulesets.
  • Remove the actual sniff in the next major, i.e. 3.0.0.

@GaryJones GaryJones changed the title VIPCS 3.0: Remove WordPressVIPMinimum.Variables.VariableAnalysis Remove WordPressVIPMinimum.Variables.VariableAnalysis Mar 7, 2023
@jrfnl jrfnl modified the milestones: 4.x, 3.x Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants