Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email change confirmation link is broken #131

Open
leogermani opened this issue Nov 6, 2021 · 2 comments
Open

Email change confirmation link is broken #131

leogermani opened this issue Nov 6, 2021 · 2 comments
Labels
bug Something isn't working. i18n All things Internationalization. [priority] high Fix/Feature needed as soon as possible.

Comments

@leogermani
Copy link

I recently changed my account email. When I got the confirmation e-mail, the link to verify the address included the leading full stop, resulting in an invalid token:

Captura de Tela 2021-11-06 às 17 24 18

See in the image above how the last . is part of the link. When I click it, I got an error message. I removed the dot from the address and everything worked fine.

Expected

I expected to click in the link and confirm the new email

Observed

When I clicked the link, I got an error message saying the link was invalid (when I removed the last dot, it worked)

Reproduced

  1. Edit your account
  2. Change the email
  3. Check the verification email you get on the new email account

Where did you see the bug

  • OS: Mac OS
  • Browser (if applicable): Firefox
  • Email client: Zoho (web)
@leogermani leogermani added the bug Something isn't working. label Nov 6, 2021
@pachlava pachlava added [priority] high Fix/Feature needed as soon as possible. i18n All things Internationalization. labels Nov 9, 2021
@pachlava
Copy link

pachlava commented Nov 9, 2021

Thanks for reporting this issue @leogermani! Simplenote team is currently working on the fix for this quite critical internationalization-related bug.

@codebykat
Copy link
Member

codebykat commented Feb 8, 2024

I believe these URLs are now being encoded correctly.

Edited: Actually I need to test this, I know it is fixed for verification tokens.

@codebykat codebykat reopened this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. i18n All things Internationalization. [priority] high Fix/Feature needed as soon as possible.
Projects
None yet
Development

No branches or pull requests

3 participants