Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useless history records generated by actions that can't be reverted by restoring previous versions #128

Open
tiagomar opened this issue Aug 28, 2021 · 3 comments
Labels
enhancement Improve existing functionality. [feature] history Anything related to history.

Comments

@tiagomar
Copy link

Actions like pinning a note are generating multiple 'fake' history records that are useless for the users since they won't see any difference when restoring any of those versions. This also happens on Android app.

Other actions:

  • Pin/Unpin notes
  • Toggle markdown
  • Publish
  • Add/Remove tags

Expected

I expected not to have a history record generated by an action that can't be reverted by restoring a previous version.

Observed

After pinning a note to the top a new history record is generated and restoring the previous version doesn't change anything.

Reproduced

  1. Create a new note
  2. Open history and verify that there is a single record
  3. Pin the note
  4. Open history and verify that a new record was added
  5. Restore the previous version
  6. Notice that the note is still pinned
@peril-automattic
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

1 similar comment
@peril-automattic
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@pachlava pachlava transferred this issue from Automattic/simplenote-ios Aug 28, 2021
@pachlava pachlava added enhancement Improve existing functionality. [feature] history Anything related to history. labels Aug 28, 2021
@pachlava
Copy link

pachlava commented Aug 28, 2021

Thanks for creating this issue @tiagomar! History feature in its current state could use some improvement indeed - as discussed in p1630152513000100/1621854790.046100-slack-C01KY08KQSY

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality. [feature] history Anything related to history.
Projects
None yet
Development

No branches or pull requests

2 participants