More modifications to improve quality

.buddyrc

@@ -1,6 +1,5 @@
 {
-  "detectObjects": false,
-  "enforceConst":  false,
-  "ignore":        [0, 1, 2, 3], 
-  "reporter":      "detailed"
+  "detectObjects": true,
+  "enforceConst":  true,
+  "reporter":  "detailed"
 }

.eslintrc → .eslintrc.json

@@ -7,6 +7,7 @@
     "rules": {
         "max-lines-per-function" : ["error", 30],
         "no-plusplus" : ["error", { "allowForLoopAfterthoughts": true }],
+        "no-console" : ["off"],
         "no-unused-vars": [
             "error",
             {

.gitignore

@@ -2,3 +2,4 @@ node_modules/
 .nyc_output/
 coverage/
 coverage.lcov
+module-depencency.svg

.madgerc

@@ -0,0 +1,12 @@
+{
+	"fontSize": "10px",
+    "backgroundColor" : "#ffffff",
+    "nodeColor": "#000000",
+    "edgeColor" : "#000000",
+    "noDependencyColor" : "#7f7f7f",
+	"graphVizOptions": {
+		"G": {
+			"rankdir": "LR"
+		}
+	}
+}

lib/cli/output/init.js

@@ -30,9 +30,11 @@ const sendError = (error) => {
 };
 
 const handleResponse = (status) => {
-  if (status.code === 200) {
+  const httpOK = 200;
+  const httpFailure = 4;
+  if (status.code === httpOK) {
     sendSuccessWelcome(status.name);
-  } else if (status.code === 4) {
+  } else if (status.code === httpFailure) {
     sendError('\nPlease check your network connection');
   } else {
     sendError('\nInvalid Username or Password');

lib/model/eval.js

@@ -21,7 +21,8 @@ const getRequestArray = (evalOptions) => {
   return [idNo, lab, commitHash, lang];
 };
 
-const socketEventHandler = (event, socket, data, callback) => { 
+/* eslint-disable max-lines-per-function */
+const socketEventHandler = (event, socket, data, callback) => {
   let response;
   switch (event) {
     case 'invalid':

lib/model/init.js

@@ -10,6 +10,7 @@ const fetchPrivateToken = async (host, username, password) => {
   };
 
   logger.moduleLog('debug', 'Init Model', `POST request to ${options.uri}`);
+  console.log(options.uri);
 
   const response = await requestPromise(options).json();
   return {
@@ -30,20 +31,22 @@ const updateCredentials = (credentials, privateToken) => {
 };
 
 const authenticate = async (credentials) => {
+  const httpOK = 200;
+  const httpFailure = 4;
   try {
     const { privateToken, name } = await fetchPrivateToken(preferenceManager.getPreference({ name: 'cliPrefs' }).gitlab.host, credentials.username, credentials.password);
     logger.moduleLog('debug', 'Init Model', `Authenticated ${name}.`);
     updateCredentials(credentials, privateToken);
     return {
-      code: 200,
+      code: httpOK,
       name,
     };
   } catch (e) {
     logger.moduleLog('error', 'Init Model', `${e}`);
     if (!e.statusCode) {
       logger.moduleLog('error', 'Init Model', 'Error code = 4');
       return {
-        code: 4,
+        code: httpFailure,
       };
     }
     return {

lib/utils/preference-manager.js

@@ -1,4 +1,3 @@
-/* eslint no-use-before-define: "warn" */
 const Preferences = require('preferences');
 const _ = require('lodash');
 const path = require('path');
@@ -32,51 +31,66 @@ const deleteCredentials = () => {
   gitLabPrefs.storedTime = -1;
 };
 
+const storeGitlabPrefs = (values) => {
+  _.assign(gitLabPrefs, values);
+
+  gitLabPrefs.storedTime = Date.now();
+};
+
+const assignValidtor = (objValue, srcValue) => (srcValue || objValue);
+
+const storeLoggerPrefs = (values) => {
+  const modValues = values;
+  const { blacklist } = modValues.logger;
+  if (blacklist && blacklist.keyword) {
+    if (_.isArray(blacklist.keyword)) {
+      _.assign(cliPrefs, {
+        logger: {
+          blacklist: blacklist.keyword,
+        },
+      });
+    } else {
+      cliPrefs.logger.blacklist.push(blacklist.keyword);
+    }
+  }
+
+  modValues.logger = _.omit(modValues.logger, 'blacklist');
+  _.assignWith(cliPrefs.logger, modValues.logger, assignValidtor);
+};
+
 const setDefaultGitlabHost = () => {
-  setPreference({
-    name: 'cliPrefs',
-    values: {
-      gitlab: {
-        host: defaultGitlab.host,
-      },
+  _.assign(cliPrefs, {
+    gitlab: {
+      host: defaultGitlab.host,
     },
   });
 };
 
 const setDefaultLanguage = () => {
-  setPreference({
-    name: 'cliPrefs',
-    values: {
-      submission: {
-        language: defaultLang,
-      },
+  _.assign(cliPrefs, {
+    submission: {
+      language: defaultLang,
     },
   });
 };
 
 const setDefaultMainServer = () => {
-  setPreference({
-    name: 'cliPrefs',
-    values: {
-      main_server: {
-        host: defaultMainServer.host,
-        port: defaultMainServer.port,
-      },
+  _.assign(cliPrefs, {
+    main_server: {
+      host: defaultMainServer.host,
+      port: defaultMainServer.port,
     },
   });
 };
 
 const setDefaultLogger = () => {
-  setPreference({
-    name: 'loggerPrefs',
-    values: {
-      logger: {
-        maxSize: defaultLogger.maxSize,
-        logDirectory: defaultLogger.logDirectory,
-        logLocation: defaultLogger.logLocation,
-        blacklist: {
-          keyword: defaultLogger.blacklist,
-        },
+  storeLoggerPrefs({
+    logger: {
+      maxSize: defaultLogger.maxSize,
+      logDirectory: defaultLogger.logDirectory,
+      logLocation: defaultLogger.logLocation,
+      blacklist: {
+        keyword: defaultLogger.blacklist,
       },
     },
   });
@@ -97,33 +111,6 @@ const setDefaultPreferences = () => {
   }
 };
 
-const storeGitlabPrefs = (values) => {
-  _.assign(gitLabPrefs, values);
-
-  gitLabPrefs.storedTime = Date.now();
-};
-
-const assignValidtor = (objValue, srcValue) => (srcValue || objValue);
-
-const storeLoggerPrefs = (values) => {
-  const modValues = values;
-  const { blacklist } = modValues.logger;
-  if (blacklist && blacklist.keyword) {
-    if (_.isArray(blacklist.keyword)) {
-      _.assign(cliPrefs, {
-        logger: {
-          blacklist: blacklist.keyword,
-        },
-      });
-    } else {
-      cliPrefs.logger.blacklist.push(blacklist.keyword);
-    }
-  }
-
-  modValues.logger = _.omit(modValues.logger, 'blacklist');
-  _.assignWith(cliPrefs.logger, modValues.logger, assignValidtor);
-};
-
 const getPreference = (options) => {
   switch (options.name) {
     case 'gitLabPrefs':