Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the render callback is always invoked #2079

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

sebastienblor
Copy link
Collaborator

Changes proposed in this pull request
This PR changes the ShouldSkipIteration function logic to be UpdateSceneChanges that will return true if the scene has changed. This function was previously returning the opposite value than what it was supposed to do. I'm thus updating the different parts of the code that are calling it.

Also, the previous logic was this if there was nothing updated in the scene, we would return "Converging" instead of calling Render(), but that's not correct. We need this callback to be invoked even if nothing has changed in the scene, as this function just checks the render status and does the necessary if the render has finished, is restarting, etc.... The reason it was working was precisely because the logic in ShouldSkipIteration was inverted, and given the high amount of calls in this function where nothing has changed, we would end up calling Render() to do what's needed.
To clarify, I'm renaming the function UpdateRender and I'm putting everything under a switch of the render status, since that's what this function was supposed to do.

Issues fixed in this pull request
Fixes #2078

@sebastienblor sebastienblor merged commit 13c144f into Autodesk:master Sep 2, 2024
9 checks passed
@sebastienblor sebastienblor deleted the pr/2078 branch September 2, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure the hydra render callback is always invoked
2 participants