Support Plane primitives in the usd procedural #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienblor
changed the title
sebastienblor
changed the title
cpichard
reviewed
Aug 8, 2024
|
ha, I wondered why we hadn't implemented them in the first place... |
|
It was added in 22.08 https://github.com/PixarAnimationStudios/OpenUSD/blob/release/CHANGELOG.md |
|
Added some ifdefs |
cpichard
approved these changes
Aug 9, 2024
|
Note that I removed here a duplicated line in the changelog |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Adding a translator reader for UsdPlane primitives, using as a reference the code from UsdImaging planes https://github.com/PixarAnimationStudios/OpenUSD/blob/release/pxr/usdImaging/usdImaging/implicitSurfaceMeshUtils.cpp#L438
Adding test_2058 with such a prim, that was already passing in hydra, and that now passes in USD too
Issues fixed in this pull request
Fixes #2058