Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix motion blur of instanced skinned geometry with animated parent matrix #2045

Merged
merged 3 commits into from
Aug 5, 2024

Conversation

cpichard
Copy link
Collaborator

@cpichard cpichard commented Aug 3, 2024

Changes proposed in this pull request

  • We interpolate transform matrices using the max number of keys between the parent and the current evaluated matrix. Before this patch, only the number of keys of the current matrix was used which could cause issue when evaluating prototypes connected to animated instances.
  • If the prim is in a prototype, we can't know if its parent instance is animated, so we return true in the function checking if the transform might be varying.
  • We add a test extracted from the scene provided in 1837, this test is reduced to a single geo to make it leaner.

Issues fixed in this pull request
Fixes #1837

sebastienblor
sebastienblor previously approved these changes Aug 4, 2024
@cpichard cpichard merged commit 2831fb5 into Autodesk:master Aug 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USD Skel motionblur is inverted
2 participants