Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Social Credit Score with Social Compatibility Index #20230

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Warbidon
Copy link

@Warbidon Warbidon commented Dec 2, 2024

🚨 BREAKING NEWS: Our favorite dystopian frogs just got a little less...Chinese? Down with the Social Score Order, up with the new Social Compatability Index hyper federalist world.

: )

Also this is a Cerriq Koh memorial pull request.

…..Chinese? Down with the Social Score Order, up with the new Social Compatailbity Index.
@FluffyGhoster
Copy link
Contributor

This would need lore approval before it can be evaluated

@FluffyGhoster FluffyGhoster added the ⛔ Lore Discussion The PR will be discussed by the maintainers due to a potential lore impact. label Dec 3, 2024
code/modules/background/citizenship/skrell.dm Outdated Show resolved Hide resolved
@@ -596,7 +596,7 @@

/obj/item/clothing/accessory/badge/passport/nralakk/get_examine_text(mob/user, distance, is_adjacent, infix, suffix)
. = ..()
. += SPAN_NOTICE("The passport displays the owner's social credit score as: [credit_score].")
. += SPAN_NOTICE("The passport displays the owner's social compatability index as: [credit_score].")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

credit_score

Maybe crtl f and swap it to compat_index or something

@WhatsUpBrotendo
Copy link
Contributor

Lore approved

@FluffyGhoster FluffyGhoster removed the ⛔ Lore Discussion The PR will be discussed by the maintainers due to a potential lore impact. label Dec 3, 2024
@Warbidon
Copy link
Author

Warbidon commented Dec 4, 2024

Reasonably sure I got every single instance of social_credit_tweaks & credit_score and changed them to be more lore friendly.

@NonQueueingMatt
Copy link
Contributor

!review

Copy link
Contributor

@FluffyGhoster FluffyGhoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the mispelling of "compatibility" intentional per lore? It seems it's used inconsistently too, so I presume not?

@Warbidon Warbidon changed the title Replace Social Credit Score with Social Compatability Index Replace Social Credit Score with Social Compatibility Index Dec 7, 2024
@Warbidon
Copy link
Author

Warbidon commented Dec 7, 2024

Is the mispelling of "compatibility" intentional per lore? It seems it's used inconsistently too, so I presume not?

I blame Brotendo for this as I copy pasted the word from their post, I don't actually know how to spell.
https://i.imgur.com/18BbRmX.png

Copy link
Author

@Warbidon Warbidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I made these changes correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants