Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor Summarize performance #46

Open
tofof opened this issue Feb 21, 2023 · 1 comment
Open

Supervisor Summarize performance #46

tofof opened this issue Feb 21, 2023 · 1 comment

Comments

@tofof
Copy link
Collaborator

tofof commented Feb 21, 2023

Very slow. Should do profiling and determine if there are poorly-optimized operations that can be sped up.

For example:

df_TH_tones = r %>% unnest(reaction) %>%
              dplyr::filter(task == "TH" & `Dur (ms)` == min_duration & `Freq (kHz)` != 0) %>% #select(-threshold, -file_name, - weight, -mean_attempts_per_trial) %>% View
              right_join(intensity, by = "date") %>%
              filter(`Inten (dB)` == desired_dB) %>%
              group_by(date) %>%
              mutate(Rxn = mean(Rxn)) %>%
              select(-desired_dB)

It's possible that moving the select to the top and joining the two filters would make this operation faster.

@tofof tofof added the performance Something is slow label Feb 21, 2023
@tofof tofof self-assigned this Feb 21, 2023
@tofof
Copy link
Collaborator Author

tofof commented Feb 24, 2023

Can cut time in half by permanently unnest_wider several parts of run_archive. Further speed improvement needs to focus on difficult regular unnests, which consume 80%+ of runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants