-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search on es #3093
Merged
Merged
Search on es #3093
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
8d3e9f8
es: track search
stereosteve 51a813c
es: multisearch tracks, users, playlists
stereosteve d8bb8a3
fix es search with no user_id present
stereosteve e462a00
track search updates almost complete set
isaacsolo 58b9cc5
more track search fields
isaacsolo 7697950
search hydrates user from ES, does user + playlist search
stereosteve 03c278f
search populates followee_reposts and favorites
stereosteve aed280f
tracks: index comma separated tags correctly
stereosteve c7fa076
bug fix none balance
isaacsolo f7d60a2
bug fix the balance indexing
isaacsolo e6ca303
fix search query artist to user and add took
isaacsolo a970f67
Merge branch 'master' into search-on-es
stereosteve 7115b88
add env var and fallback
isaacsolo 37c022b
skip mat view refresh if ES search enabled
stereosteve 500cb95
default all search
isaacsolo d753f1a
add saved entities and albums search, needs refactoring
isaacsolo d381ce9
Use ES for autocomplete
stereosteve e95d7e2
deep copy query dsl before changing
stereosteve 6d39fb7
search_as_you_type for autocomplete
stereosteve 0d6d3af
add integration tests against ES searches and fix some bugs
isaacsolo 2369a06
fix test fixtures + add index refresh
isaacsolo f6c8874
shorten timeout
isaacsolo 178fc61
script to print test searches
stereosteve de21e43
Dedicated suggest field.
stereosteve d47f8c4
search scoring tweaks, use autocomplete query everywhere
stereosteve 8a0c41b
Apply ES search for all APIs
isaacsolo 3e92a70
es scoring tweaks
stereosteve bd927fd
tune scoring + add scores to script
isaacsolo 2713510
add personalization
isaacsolo 093e160
unbreak es search
stereosteve 87bc6fc
fix circular import
stereosteve 671abb7
refactor search hydrate code
stereosteve bed6ea3
filter copycats from search results
stereosteve bee8bb4
move script
isaacsolo 581e5a9
update playlist query
isaacsolo 8e740bc
cleanup comments
isaacsolo 623884a
refactor es dsl building code
stereosteve a7d927d
add fuzziness
isaacsolo 6cd2b7e
Add note about current_user_followee_follow_count
stereosteve 015487c
edit test env
isaacsolo 2132760
small naming fixes
isaacsolo d3cfe6f
lint
isaacsolo b0a6642
dedupe user type
isaacsolo b060030
Merge branch 'master' into search-on-es
isaacsolo 1729393
lower + asciifolding for all analyzed fields
stereosteve 169ebf5
Add some over-fetching on user search for drop_copycats
stereosteve File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,7 @@ | ||
# TODO: dummy ganache keys for local setup; should wire with dynamically generated keys | ||
audius_delegate_owner_wallet=0x1D9c77BcfBfa66D37390BF2335f0140979a6122B | ||
audius_delegate_private_key=0x3873ed01bfb13621f9301487cc61326580614a5b99f3c33cf39c6f9da3a19cad | ||
audius_solana_rewards_manager_account=8MzNUaBHskteN7poTrZG5wgSNSbXQwieMDB4wk9fgB7f | ||
audius_solana_rewards_manager_account=8MzNUaBHskteN7poTrZG5wgSNSbXQwieMDB4wk9fgB7f | ||
|
||
audius_elasticsearch_url=http://localhost:9200 | ||
audius_db_url=postgresql+psycopg2://postgres:postgres@localhost:5432/test_audius_discovery |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
export const indexNames = { | ||
playlists: 'playlists2', | ||
playlists: 'playlists6', | ||
reposts: 'reposts2', | ||
saves: 'saves2', | ||
tracks: 'tracks2', | ||
users: 'users2', | ||
tracks: 'tracks6', | ||
users: 'users6', | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this take a while?
If already logging, might be nice to record the time it takes as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a few ms each index so probably ok without logging. it was added here since we extended the refresh_interval to 5s. an edge case would be when the indexer first catches up we want to refresh before making it available otherwise there could be no results for a few seconds. it's also necessary for test cases since we don't want to wait 5s.