Skip to content

Commit

Permalink
[C-2404] Fix ios build on xcode 14.3 (#3146)
Browse files Browse the repository at this point in the history
  • Loading branch information
dylanjeffers authored Apr 3, 2023
1 parent 186a086 commit d799e30
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
21 changes: 20 additions & 1 deletion packages/mobile/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ target 'AudiusReactNative' do
:mac_catalyst_enabled => false
)
__apply_Xcode_12_5_M1_post_install_workaround(installer)
__apply_Xcode_14_3_RC_post_install_workaround(installer)


installer.pods_project.build_configurations.each do |config|
Expand All @@ -73,4 +74,22 @@ target 'AudiusReactNative' do
end
end
end
end
end

# https://github.com/facebook/react-native/commit/cb88e75cf1f82af94e35f1647f6b6d0b0dbbe60f
# https://github.com/travis-mark/lrn/commit/015854716feadd61a904d5a603b027426472f863
# Force pods to match minimum iOS version for React Native
# Fixes build issue on Xcode Cloud where some pods
# Use iOS 12 calls despite being set as iOS 11
def __apply_Xcode_14_3_RC_post_install_workaround(installer)
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
current_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET']
minimum_target = min_ios_version_supported
if current_target.to_f < minimum_target.to_f
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = minimum_target
end
end
end
end

2 changes: 1 addition & 1 deletion packages/mobile/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1200,6 +1200,6 @@ SPEC CHECKSUMS:
Yoga: 5ed1699acbba8863755998a4245daa200ff3817b
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a

PODFILE CHECKSUM: e5d6450acb3370a25a796e24c0b62788c0ec984e
PODFILE CHECKSUM: 78cdf226103f577ea16b8c2f2aecf246eefc2a97

COCOAPODS: 1.11.3

0 comments on commit d799e30

Please sign in to comment.