linter-reek passing invalid messages to linter

[Arcanemagus]

It appears that linter-reek is passing messages of an invalid format to the linter package, causing issues to be reported against the linter package (steelbrain/linter#850 (comment)).

Steps to reproduce:

1. Open a fresh Atom profile
2. Install linter and linter-reek packages
3. Create a Ruby file with content (I used the example here)
4. Trigger a lint

[steelbrain]

In any case, we should be catching those invalid messages in linter, can I get to see an example invalid error object please?

[Arcanemagus]

JSON.stringify(message)
"{"type":"warning","text":["Dirty#awful has unused parameter 'y' (UnusedParameters)\r\n",""],"filePath":"C:\\Users\\Landon\\Desktop\\wtf.rb","range":{"start":{"row":0,"column":0},"end":{"row":0,"column":0}},"key":"{\"type\":\"warning\",\"text\":[\"Dirty#awful has unused parameter 'y' (UnusedParameters)\\r\\n\",\"\"],\"filePath\":\"C:\\\\Users\\\\Landon\\\\Desktop\\\\wtf.rb\",\"range\":{\"start\":{\"row\":0,\"column\":0},\"end\":{\"row\":0,\"column\":0}}}","class":"warning","currentFile":true,"currentLine":false}"

Need anything else? It looks like text is an array and shouldn't be.

[steelbrain]

Ah right. I think we're gonna need a spec for that in the core linter, as well as a type check.

[kieranklaassen]

+1

[mttrs]

+1

[Arcanemagus]

@dhagerty9009 will you be able to take this on, or do you want somebody else to take a look?

[dathagerty]

I'm a little swamped at work, so if someone else can fix this issue that would be fantastic.

[dathagerty]

I'm closing this issue, as #13 has been merged in.