Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Object.dirname is deprecated. #296

Closed
almostsultry opened this issue Oct 9, 2017 · 2 comments · Fixed by #316
Closed

Object.dirname is deprecated. #296

almostsultry opened this issue Oct 9, 2017 · 2 comments · Fixed by #316
Labels
bug good first issue released

Comments

@almostsultry
Copy link

Argument to path.dirname must be a string

Object.dirname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
Object.<anonymous> (/Users/captbackfire/.atom/packages/linter-phpcs/lib/main.js:198:28)
Generator.next (null:null:null)
step (/Users/captbackfire/.atom/packages/linter-phpcs/lib/main.js:5:273)
<unknown> (/Users/captbackfire/.atom/packages/linter-phpcs/lib/main.js:5:443)
lint (/Users/captbackfire/.atom/packages/linter-phpcs/lib/main.js:5:99)
@Arcanemagus Arcanemagus added the bug label Oct 9, 2017
@Arcanemagus
Copy link
Member

Easily solved in a manner similar to AtomLinter/linter-shellcheck#109.

@pattonwebz pattonwebz mentioned this issue Jun 13, 2018
Merged
@Arcanemagus
Copy link
Member

🎉 This issue has been resolved in version 1.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bail early if no filePath exists to use pattonwebz/linter-phpcs
2 participants
@Arcanemagus @almostsultry