Merge pull request #95 from AtomLinter/steelbrain/do-not-change-path

Do not modify process.env
steelbrain · Jan 11, 2016 · cecba77 · cecba77
2 parents fffb5f0 + 60c3942
commit cecba77
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### Upcoming
+
+* Fix a bug where linter execution modifies `process.env`
+
 ### 4.3.1
 
 * Remove `createElement` helper, reason is nobody was using it (according to GitHub code search)

diff --git a/lib/helpers.js b/lib/helpers.js
@@ -47,7 +47,7 @@ const assign = Object.assign || function (target, source) {
 
 function _exec(command, args, opts, isNode) {
   const options = assign({
-    env: process.env,
+    env: assign({}, process.env),
     stream: 'stdout',
     throwOnStdErr: true
   }, opts);

diff --git a/src/helpers.js b/src/helpers.js
@@ -19,7 +19,7 @@ const assign = Object.assign || function(target, source) {
 
 function _exec(command, args, opts, isNode) {
   const options = assign({
-    env: process.env,
+    env: assign({}, process.env),
     stream: 'stdout',
     throwOnStdErr: true
   }, opts)