Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip resources with empty eml #171

Merged

Conversation

vjrj
Copy link
Contributor

@vjrj vjrj commented Mar 9, 2021

We have an external IPT with a testing dr with its eml empty. This causes that we cannot sync other valid resources from this data provider. The error:

2021-03-09 13:02:57,870 ERROR [IptController] Problem scanning IPT endpoint: Target host is null
java.lang.IllegalStateException: Target host is null
        at org.apache.http.util.Asserts.notNull(Asserts.java:46)
        at org.apache.http.impl.conn.DefaultHttpRoutePlanner.determineRoute(DefaultHttpRoutePlanner.java:98)
        at org.apache.http.impl.client.DefaultRequestDirector.determineRoute(DefaultRequestDirector.java:762)
        at org.apache.http.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:381)
        at org.apache.http.impl.client.AbstractHttpClient.doExecute(AbstractHttpClient.java:863)
        at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:82)
        at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:57)
        at groovyx.net.http.HTTPBuilder.doRequest(HTTPBuilder.java:476)
        at groovyx.net.http.HTTPBuilder.get(HTTPBuilder.java:292)
        at groovyx.net.http.HTTPBuilder.get(HTTPBuilder.java:262)
        at au.org.ala.collectory.IptService.retrieveEml(IptService.groovy:225)

2021-01-09-13-27-50-screenshot

This PR adds an extra condition for these cases.

@vjrj vjrj requested a review from djtfmartin March 9, 2021 14:22
@djtfmartin djtfmartin merged commit bcda8c4 into AtlasOfLivingAustralia:develop Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants