Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor login buttons to use dropdown #14

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

arashsheyda
Copy link
Contributor

With more providers getting added, this design allows better organization and presentation.

Screen.Recording.2023-11-11.at.9.40.39.AM.mov

@atinux
Copy link
Owner

atinux commented Nov 11, 2023

I was actually thinking of doing this or directly use card in the main page for each provider

You read my mind :D

@arashsheyda
Copy link
Contributor Author

I'm glad we're thinking the same :D
Card will look good too actually, maybe we can add both? or dropdown is enough?

@atinux
Copy link
Owner

atinux commented Nov 11, 2023

Let's keep the dropdown for now 😀

I will have to deploy the playground also to have a nice demo.

But need to create all the OAuth apps 😆

@arashsheyda
Copy link
Contributor Author

Yeah that'd be nice, also I think some docs would be helpful, I can work on that if you think it's a good idea

@atinux
Copy link
Owner

atinux commented Nov 12, 2023

More docs than what we have on the readme? What are you thinking of?

@arashsheyda
Copy link
Contributor Author

Oh sorry my last comment is not that clear now that I read it :d I think we can add the providers developer links(similar to what you wrote in nuxt-todo-edge setup for github)

and with a website maybe we can add examples page so user can try the features out

@atinux atinux merged commit 76357c6 into atinux:main Nov 13, 2023
3 checks passed
@arashsheyda arashsheyda deleted the feat/playground-dropdown branch November 14, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants