-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
median_otsu misused in three_tissue_response_dhollander16 #76
Comments
Hi @matteofrigo, "b0_mask, mask = median_otsu(data, 2, 1)" still makes the problem of iteration. I am guessing that the median_otsu line is based on dipy example. You may want to update three_tissue_response.py median_otsu line to: b0_mask, mask = median_otsu(data, median_radius=2, numpass=1) |
Hi @heejong-kim, following your comment I just updated the usage of the median_otsu function as suggested. Things should work now as expected! |
The
median_otsu
method fromdipy
takes as input the variablevol_idx
which must be an iterable.In the
three_tissue_response_dhollander16
function this parameter is passed as a scalar.I'll fix it and push a PR, but we should be aware of the fact that this could be happening somewhere else. It may be due to the recent dipy update (v1.0) but again, I'm not sure and this must be checked.
The text was updated successfully, but these errors were encountered: