Removing rbacProvider from pkg contoller.go file #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdayMadhav88
force-pushed
the
uday-patch-1
branch
25 times, most recently
from
2f8c26a
to
af473a8
Compare
UdayMadhav88
force-pushed
the
uday-patch-1
branch
2 times, most recently
from
48811b2
to
7fb77d9
Compare
UdayMadhav88
force-pushed
the
uday-patch-1
branch
from
5be579e
to
f980925
Compare
| apController := authzpolicy.NewController(configStoreCache, serviceIndexInformer, adIndexInformer, istioClientSet, 30*time.Second, enableOriginJwtSubject, componentsEnabledAuthzPolicy, combinationPolicyTag, authPolicyControllerOnlyMode, enableSpiffeTrustDomain, []string{"istio-system", "kube-yahoo"}, map[string]string{"istio-ingressgateway": "istio-system"}, []string{"k8s.omega.stage"}) | ||
| go apController.Run(stopCh) | ||
|
|
||
| log.InitLogger("", "debug") |
There was a problem hiding this comment.
Please remove this line as it is no longer needed.
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
…Clusterrbacconfigs IstioRbacV1Alpha1Serviceroles under the collections package Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
…file Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
UdayMadhav88
force-pushed
the
uday-patch-1
branch
from
3b5d96b
to
c2560f8
Compare
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
bhaskaramVaranasi
approved these changes
Sep 13, 2024
zetaj
approved these changes
Sep 16, 2024
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Signed-off-by: UdayMadhav88 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes made in this PR.
The main agenda is to remove rbac v1 from the code.
Removed rbacProvider, dependencies of rbacv1 and sync function from pkg contoller.go file .
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Reviewers
@bhaskaramVaranasi