feat: Remote config feature toggle for ticketing #589
Conversation
| Frem til da kan du kjøpe billett fra{'\n'} | ||
| <Text onPress={openOtherTicketingApp} style={styles.underline}> | ||
| AtB Mobillett | ||
| </Text> | ||
| </Text> | ||
| <Text style={styles.text}> | ||
| Hvis du har en kode for å melde deg inn i beta for billettkjøp -{' '} | ||
| <Text |
There was a problem hiding this comment.
Does this require something for accessibility? Or is the modal itself buggy for screen readers in any case?
There was a problem hiding this comment.
The modal might be buggy in any case, sadly. This doesn't excuse not choosing a different implementation - but I think addressing modal accessibility is a different PR
I don't think this requires something else, but maybe @rikkekantega is the best person to answer that?
| </View> | ||
| <View style={styles.bannerContainer}> | ||
| <ShinyTicketBanner | ||
| width={windowWidth} | ||
| height={windowWidth / 2} | ||
| ></ShinyTicketBanner> | ||
| </View> | ||
| <InviteModal ref={modalRef} onEnrolled={onEnrolled} /> |
There was a problem hiding this comment.
why not just use refresh directly?
There was a problem hiding this comment.
Aforementioned async bug - it just wouldn't work :/ I can try to reproduce it tomorrow
|
Still some unanswered questions, but I'm merging to get this in. I'll take a look at accessibility++ tomorrow |
Dependent on AtB-AS/atb-bff#43
Changes
beta_group(concat groups id's so we can support several at once).refreshremote configScreenshots