Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Header title first focus #651

Merged
merged 3 commits into from
Nov 6, 2020
Merged

feat: Header title first focus #651

merged 3 commits into from
Nov 6, 2020

Conversation

rikkekantega
Copy link
Contributor

Accessible and reordered header title for all headers.
This makes screen readers read out title first after navigating to a new screen.

cbrevik
cbrevik approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@cbrevik cbrevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :D If it's this simple that would be awesome

@rikkekantega
Copy link
Contributor Author

Awesome! :D If it's this simple that would be awesome

Should be for this exact issue. Must verify that this works on iOS though :)

@rikkekantega rikkekantega merged commit e453a6a into master Nov 6, 2020
@rikkekantega rikkekantega deleted the rikke/traveldetail-focus branch November 6, 2020 13:54
This was referenced Nov 8, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrevik cbrevik cbrevik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rikkekantega @cbrevik