fix(assistant): Fixes possible bug when incorrect data is returned for trip patterns #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r trip patterns fixes #598
mikaelbr
force-pushed
the
mikael/fix-598
branch
from
e838f95 to
73d2270
Compare
This was referenced Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes AtB-AS/kundevendt#796
This is kind of silly, I'll admit. See comment AtB-AS/kundevendt#796. There exists a possibility that response data is something other than what we expect. Should probably have some proper validation here (and for API data layers in general, but we can do that as a part of the technical rewrites with the BFF). In the meantime, since this has happened once, it can happen again – even if I don't know the root cause of this. Again, yes, silly.