Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds ability to search for favorites. fixes #422 #590

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

mikaelbr
Copy link
Collaborator

Closes AtB-AS/kundevendt#1409

This adds the ability to search on both favorite names and prioritizes favorite locations when searching on addresses.

There are a lot of types in regards to favorites and search here. Many of them similar and overlapping. Could clean up some to reuse types and make it more consistent, but didn't do it as a part of this feature as it is focused more on the quick-win.
Screenshot 2020-10-23 at 09 11 18

Copy link
Contributor

@rikkekantega rikkekantega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Seems to work as intended, and will be a really nice improvement

@mikaelbr mikaelbr merged commit 5b04f11 into master Oct 23, 2020
@mikaelbr mikaelbr deleted the mikael/search-favorites branch October 23, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants