fix(dial-nvim): lazify dial-nvim, add month / weekday crementing #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Since we already add mappings, we might as well lazy-load the plugin
The reasoning behind putting the
g
mappings in visual mode only, is thatv
maps to both visual mode and select mode.Select mode is used in luasnip, for insert nodes that have text inside of them.
The user might expect to be able to just type in the letter g, but instead these two dial mappings will hold on the user pressing g, rather than immediatley continuing.
Can't think of another reason to be in select mode aside from that, so I don't see a disadvantage in making the experience less annoying with luasnip.
I found it super useful to be able to decrement / increment month names and weekdays, so, I added it as well.
ℹ Additional Information