Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dial-nvim): lazify dial-nvim, add month / weekday crementing #881

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

Axlefublr
Copy link
Contributor

  • lazify plugin
  • add increment / decrement month / weekday

📑 Description

Since we already add mappings, we might as well lazy-load the plugin

The reasoning behind putting the g mappings in visual mode only, is that v maps to both visual mode and select mode.
Select mode is used in luasnip, for insert nodes that have text inside of them.
The user might expect to be able to just type in the letter g, but instead these two dial mappings will hold on the user pressing g, rather than immediatley continuing.
Can't think of another reason to be in select mode aside from that, so I don't see a disadvantage in making the experience less annoying with luasnip.

I found it super useful to be able to decrement / increment month names and weekdays, so, I added it as well.

ℹ Additional Information

Copy link

github-actions bot commented Apr 14, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Axlefublr Axlefublr changed the title lazify dial-nvim, add month / weekday crementing fix(dial-nvim): lazify dial-nvim, add month / weekday crementing Apr 14, 2024
@Uzaaft Uzaaft merged commit da97c99 into AstroNvim:main Apr 14, 2024
12 checks passed
@Axlefublr Axlefublr deleted the dial-nvim branch April 14, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants