Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mason-tool-installer-nvim): Use mappings function for null-ls names #841

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

krzysztofgb
Copy link
Contributor

📑 Description

Replaces null_ls_to_package mappings table with mason-null-ls's provided getPackageFromNullLs function for mapping package names to Mason names.

ℹ Additional Information

  • Link to mason-null-ls function used: here
    • This function uses the null_ls_to_package table under the hood while also fixing the names of package names following "normal" conventions
    • This function was introduced here and a lot of "normal" mappings (including clang_format -> clang-format) got removed from the mapping sources as a result
  • This provides an alternative fix to the issue I was having in fix(java): rename clang_format to clang-format #837

Copy link

github-actions bot commented Apr 7, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@krzysztofgb krzysztofgb changed the title fix(mason-tool-installer-nvim): Update mappings function for mason-nu… fix(mason-tool-installer-nvim): Use mappings function for null-ls names Apr 7, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Apr 7, 2024

@mehalter You're the expert on this stuff, more than me 😅 Can you take a look whenever you get time and see if this makes sense?

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mehalter mehalter merged commit a692178 into AstroNvim:main Apr 7, 2024
16 checks passed
This was referenced Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants