Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bash): fix duplicate diagnostics in bash pack #804

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

lucazz
Copy link
Contributor

@lucazz lucazz commented Mar 18, 2024

📑 Description

While using the bash pack, I came across a this odd behavior: Bash diagnostics showing up as duplicates:
Screenshot 2024-03-18 at 12 33 08

This takes place because, as referenced here and here, bash-ls has a shellcheck integration by default. So there is no need to set it up as a secondary source.

This PR removes shellcheck from the list of language servers installed by mason to be configured and used by null-ls/none-ls

Copy link

github-actions bot commented Mar 18, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@lucazz lucazz changed the title Fix duplicate diagnostics in bash pack fix(pack): Fix duplicate diagnostics in bash pack Mar 18, 2024
@lucazz lucazz changed the title fix(pack): Fix duplicate diagnostics in bash pack fix(pack): fix duplicate diagnostics in bash pack Mar 18, 2024
@lucazz lucazz force-pushed the fix-duplicate-diagnostics branch from bb911e6 to 1c0660e Compare March 18, 2024 19:09
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter changed the title fix(pack): fix duplicate diagnostics in bash pack fix(bash): fix duplicate diagnostics in bash pack Mar 19, 2024
@mehalter mehalter merged commit 570a524 into AstroNvim:main Mar 19, 2024
15 checks passed
@lucazz lucazz deleted the fix-duplicate-diagnostics branch March 20, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants