Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): Migrate to built-in treesitter #743

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

dzonatan
Copy link
Contributor

https://github.com/nvim-treesitter/nvim-treesitter-angular is deprecated (and archived) since Angular support is included in nvim-treesitter itself.

Without this fix, currently running :TSUpdate angular fails with:

nvim-treesitter[angular]: Error during tarball extraction.                                                                                                                                     
tar: Error opening archive: Unrecognized archive format  

It almost seems unrelated, but it is nvim-treesitter/nvim-treesitter#5246

https://github.com/nvim-treesitter/nvim-treesitter-angular is deprecated (and archived) since support is included in `nvim-treesitter` itself.
Copy link

github-actions bot commented Jan 29, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@luxus luxus self-requested a review January 29, 2024 15:37
@Uzaaft
Copy link
Member

Uzaaft commented Jan 29, 2024

@dzonatan Can you see if they’re fixed the JSX issues that the fork fixed?

@dzonatan
Copy link
Contributor Author

Can't reproduce so I guess it's fine.
Also, at some point the "fix" was merged into the main repo nvim-treesitter/nvim-treesitter-angular#4

@Uzaaft Uzaaft changed the title fix(angular): use built-in treesitter feat(angular): Migrate to built-in treesitter Jan 30, 2024
@Uzaaft Uzaaft merged commit 8157924 into AstroNvim:main Jan 30, 2024
17 checks passed
@dzonatan dzonatan deleted the patch-1 branch January 30, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants