Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(octo-nvim): adjusted whichkey description mapping #645

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

jharlow
Copy link
Contributor

@jharlow jharlow commented Nov 18, 2023

📑 Description

Previously 'Resume review' was 'Start resume', this switch makes for a more intuitive description and aligns the first letter with the mapping. Not a big deal in the long run but I took way too long to find that mapping so figured a tiny PR wouldn't hurt :)

Previously 'Resume review' was 'Start resume', this switch makes for a more intiuitive description and aligns the first letter with the mapping
Copy link

github-actions bot commented Nov 18, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@jharlow jharlow marked this pull request as ready for review November 18, 2023 21:59
@Uzaaft Uzaaft changed the title fix(octo): adjusted whichkey description mapping fix(octo-nvim): adjusted whichkey description mapping Nov 19, 2023
@Uzaaft Uzaaft merged commit 164c035 into AstroNvim:main Nov 19, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants