Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openingh-nvim): more precise lazy loading with "cmd" and "keys" #527

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

RayJameson
Copy link
Contributor

@RayJameson RayJameson commented Aug 20, 2023

📑 Description

Use keys and cmd for lazy loading openingph-nvim instead of event
I made the description of the keys generic on purpose because the plugin author states that it supports not only Github but also other git hosting sites. Also, this plugin has a nice notification message if you try to use it not inside a git repository so I don't see a problem with using cmd and keys

@github-actions
Copy link

github-actions bot commented Aug 20, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title chore(openingh-nvim): more precise lazy loading with "cmd" and "keys" feat(openingh-nvim): more precise lazy loading with "cmd" and "keys" Aug 20, 2023
@Uzaaft Uzaaft changed the title feat(openingh-nvim): more precise lazy loading with "cmd" and "keys" fix(openingh-nvim): more precise lazy loading with "cmd" and "keys" Aug 20, 2023
@Uzaaft Uzaaft merged commit 4225f20 into AstroNvim:main Aug 20, 2023
Uzaaft pushed a commit that referenced this pull request Aug 29, 2023
…527)

chore(openingh-nvim): more precise lazy loading with "cmd" and "keys"
Uzaaft pushed a commit that referenced this pull request Sep 3, 2023
…527)

chore(openingh-nvim): more precise lazy loading with "cmd" and "keys"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants