Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make which-key entry color blue, as it should be #424

Merged

Conversation

RayJameson
Copy link
Contributor

@RayJameson RayJameson commented Jul 13, 2023

This PR fixes remaining plugins with wrong which-key colors

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@RayJameson RayJameson force-pushed the fix/which-key/you-know-how-it-goes branch from 21c4ba8 to f5ca5b8 Compare July 13, 2023 16:38
@RayJameson
Copy link
Contributor Author

I'm not sure which scope should it be in PR subject

@owittek
Copy link
Member

owittek commented Jul 13, 2023

@mehalter will have to merge this due to the PR message not having a scope

@owittek owittek requested a review from mehalter July 13, 2023 16:42
@RayJameson RayJameson force-pushed the fix/which-key/you-know-how-it-goes branch from f5ca5b8 to 9b11631 Compare July 13, 2023 16:43
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit aea716a into AstroNvim:main Jul 13, 2023
@RayJameson RayJameson deleted the fix/which-key/you-know-how-it-goes branch July 14, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants