Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(html-css): add emmet_ls to html-css supprt syntax like li * 5 #347

Merged
merged 2 commits into from
Jul 2, 2023
Merged

feat(html-css): add emmet_ls to html-css supprt syntax like li * 5 #347

merged 2 commits into from
Jul 2, 2023

Conversation

chaozwn
Copy link
Contributor

@chaozwn chaozwn commented Jul 2, 2023

add emmet_ls to html-css supprt syntax like li * 5

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title feat(pack): add emmet_ls to html-css supprt syntax like li * 5 feat(html-css): add emmet_ls to html-css supprt syntax like li * 5 Jul 2, 2023
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 247d1f2 into AstroNvim:main Jul 2, 2023
Uzaaft pushed a commit that referenced this pull request Jul 3, 2023
…347)

* feat(pack): add emmet_ls to html-css supprt syntax like `li * 5`

* feat(pack): update html-css readme.
@tofulm
Copy link

tofulm commented Jul 15, 2023

@chaozwn do you know : https://github.com/kozer/emmet-language-server
I tested it, and it's better than emmet-ls

@Uzaaft
Copy link
Member

Uzaaft commented Jul 15, 2023

kozer/emmet-language-server seems unmaintained

@tofulm
Copy link

tofulm commented Jul 16, 2023

@Uzaaft
Copy link
Member

Uzaaft commented Jul 16, 2023

It's very new, so I think we should stay away from it for now. Perhaps we'll move to it in the future.

@chaozwn
Copy link
Contributor Author

chaozwn commented Jul 19, 2023

sorry, it's https://github.com/olrtg/emmet-language-server

emmet_language_server can not transform m5 to margin: 5px,.Their functionalities are almost identical, unless there are obvious bugs. Currently, I don't feel that this new Emmet LSP has any essential features that require switching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants