Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(motion): vim-matchup - matchup_matchparen_offscreen method='popup… #331

Merged
merged 2 commits into from
Jun 29, 2023
Merged

fix(motion): vim-matchup - matchup_matchparen_offscreen method='popup… #331

merged 2 commits into from
Jun 29, 2023

Conversation

jay-babu
Copy link
Contributor

…' #279

@jay-babu jay-babu mentioned this pull request Jun 29, 2023
Closed
mehalter
mehalter requested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, do you think we should also add

vim.g.matchup_matchparen_deferred = 1

to the default options as well?

@jay-babu
Copy link
Contributor Author

Awesome, do you think we should also add

vim.g.matchup_matchparen_deferred = 1

to the default options as well?

sure, why not. i just turned the issue into a PR

mehalter
mehalter approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mehalter mehalter merged commit 840e049 into AstroNvim:main Jun 29, 2023
@mehalter mehalter mentioned this pull request Jun 29, 2023
Merged
Uzaaft pushed a commit that referenced this pull request Jul 1, 2023
@jay-babu @Uzaaft
fix(motion): vim-matchup - matchup_matchparen_offscreen method='popup… (
d2e6768 
#331)

* fix(motion): vim-matchup - matchup_matchparen_offscreen method='popup' #279

* Update lua/astrocommunity/motion/vim-matchup/init.lua
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jay-babu @mehalter