feat(harpoon)!: remove "j" keymap, make "t" keymap dynamic based on $TMUX

[RayJameson]

I believe it's better when you have to remember one less keybinding.
Hope nobody gets upset because of the removed "j" keymap.
I may add it for compatibility

[RayJameson]

This also fixes which key preview, by adding an empty function. Before it was <prefix><prefix>, now it's 󱡀 Harpoon, however I didn't figure out how to make it blue color as it should be.

[RayJameson]

randomly fixed the error that occurred if user canceled input when using the "go to terminal" thing, also added a new keymap to jump to the index of the mark

[luxus]

anyone else that uses harpoon can confirm that?

[RayJameson]

@luxus on second thought, maybe it's better to leave keymaps unchanged as they do not contradict each other. You can still make :term while using TMUX, maybe someone using it. And in my experience, the require("harpoon.tmux").gotoTerminal(num) doesn't work as intended, I checked the plugin repo and there is at least one open issue that repeats my experience:

• Harpoon tmux go to terminal (window) does not work if user creates sessions with tmux panes ThePrimeagen/harpoon#180

I can remove remap part and leave everything else

[mehalter]

Hey @RayJameson just a heads up, I went ahead and rebased this on main because there was a bit of standardization that was done for filenames

[owittek]

This also fixes which key preview, by adding an empty function. Before it was <prefix><prefix>, now it's 󱡀 Harpoon, however I didn't figure out how to make it blue color as it should be.

Could you please elaborate what the empty function fixes exactly? Having any functionality (like an anonymous function) leads to the which-key entry not being colored.

[RayJameson]

This also fixes which key preview, by adding an empty function. Before it was <prefix><prefix>, now it's 󱡀 Harpoon, however I didn't figure out how to make it blue color as it should be.

Could you please elaborate what the empty function fixes exactly? Having any functionality (like an anonymous function) leads to the which-key entry not being colored.

You're correct, however, without it it is named "prefix", I guess it's either one or another, unless you know the way, how to make it colored and with the correct description.

How does it look now:

How does it look with empty function:

• with enabled icons

• with disabled icons

By the way it is not only this plugin problem, trouble.nvim has similar mapping, and it's also just "prefix", I believe it's every plugin which set keymap without action

[mehalter]

A few small comments about more easily setting variables and small typo fix

[mehalter]

LGTM!

[mehalter]

@RayJameson I think the last thing before we merge, is do you think you could come up with a good way to word the fact that there are binding changes from this commit? I think that would take higher precedence than the dynamic changing of the text in the message

[RayJameson]

@mehalter done

[mehalter]

Thanks for your work on this @RayJameson ! ❤️