Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utility): Add in live-server.nvim #1270

Merged
merged 3 commits into from
Nov 21, 2024
Merged

feat(utility): Add in live-server.nvim #1270

merged 3 commits into from
Nov 21, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Nov 16, 2024

Closes #1190

Copy link

github-actions bot commented Nov 16, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft changed the title feat(programmmmming-language-support): Add in live-server.nvim feat(programming-language-support): Add in live-server.nvim Nov 16, 2024
@Uzaaft Uzaaft requested a review from a team November 18, 2024 20:15
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should probably go under editing-support or utility. It doesn't really have anything to do with supporting a programming language

@Uzaaft
Copy link
Member Author

Uzaaft commented Nov 18, 2024

I think this should probably go under editing-support or utility. It doesn't really have anything to do with supporting a programming language

Moving to utility.

@Uzaaft
Copy link
Member Author

Uzaaft commented Nov 18, 2024

Done.

@Uzaaft Uzaaft requested review from mehalter and a team November 18, 2024 20:20
@mehalter mehalter changed the title feat(programming-language-support): Add in live-server.nvim feat(utility): Add in live-server.nvim Nov 19, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Uzaaft Uzaaft merged commit e986131 into main Nov 21, 2024
14 checks passed
@Uzaaft Uzaaft deleted the dev/live-server branch November 21, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add live server.nvim
2 participants