Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): fix typo in harper's mason-lspconfig override #1266

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Nov 10, 2024

📑 Description

According to https://github.com/williamboman/mason-lspconfig.nvim, the correct identifier for this language server in mason-lspconfig is harper_ls, not harper-ls.

According to https://github.com/williamboman/mason-lspconfig.nvim, the correct identifier for this language server in `mason-lspconfig` is `harper_ls`, not `harper-ls`.
Copy link

github-actions bot commented Nov 10, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft changed the title fix(pack): fix typo in harper's mason-lspconfig override fix(harper): fix typo in harper's mason-lspconfig override Nov 11, 2024
@Uzaaft
Copy link
Member

Uzaaft commented Nov 11, 2024

@rami3l Please use the right pr title and scope.

@Uzaaft Uzaaft merged commit 4f1af4b into AstroNvim:main Nov 11, 2024
19 checks passed
@rami3l rami3l changed the title fix(harper): fix typo in harper's mason-lspconfig override fix(pack): fix typo in harper's mason-lspconfig override Nov 11, 2024
@rami3l rami3l deleted the patch-1 branch November 11, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants