Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): add magazine.nvim #1238

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

ALameLlama
Copy link
Member

📑 Description

Adds magazine.nvim, This replaces nvim-cmp and acts as a "beta" with performance and feature improvements before they get up streamed.

Copy link

github-actions bot commented Oct 10, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft
Copy link
Member

Uzaaft commented Oct 11, 2024

@ALameLlama Shouldnt this replce nvim-cmp?

@ALameLlama
Copy link
Member Author

@Uzaaft Since this is using the same name as nvim-cmp it is replacing it, and you can't use specs to disable nvim-cmp since by that point it's already taken the name.

image

Unless I've misunderstood your comment or how we can uninstall nvim-cmp programmatically first before installing magazine.nvim

@Uzaaft
Copy link
Member

Uzaaft commented Oct 13, 2024

@Uzaaft Since this is using the same name as nvim-cmp it is replacing it, and you can't use specs to disable nvim-cmp since by that point it's already taken the name.

image

Unless I've misunderstood your comment or how we can uninstall nvim-cmp programmatically first before installing magazine.nvim

I guess one way to go is to set the url of nvim-cmp, like this:

  { "hrsh7th/nvim-cmp", url = "https://github.com/iguanacucumber/magazine.nvim.git" },

Gonna cc in @mehalter in case he has an opinion.

@mehalter
Copy link
Member

I think I have a good solution for this. I've been also mulling over how to achieve this nicely. I'll give a recommendation on Monday

@mehalter mehalter force-pushed the feature/add-magazine-nvim branch from 2191331 to 4de5c80 Compare October 14, 2024 13:58
@mehalter
Copy link
Member

@ALameLlama I revised the commit to set up magazine.nvim to hijack an existing nvim-cmp installation and just be there to update the runtime path. So all the configuration for users is still done through nvim-cmp as normal and this plugin spec only exists to update the runtime path for where the cmp module lives.

Let me know what you think!

@mehalter mehalter merged commit 8b024ad into main Oct 14, 2024
13 of 14 checks passed
@mehalter mehalter deleted the feature/add-magazine-nvim branch October 14, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants