-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(completion): add magazine.nvim #1238
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
@ALameLlama Shouldnt this replce nvim-cmp? |
@Uzaaft Since this is using the same name as nvim-cmp it is replacing it, and you can't use specs to disable nvim-cmp since by that point it's already taken the name. Unless I've misunderstood your comment or how we can uninstall nvim-cmp programmatically first before installing magazine.nvim |
I guess one way to go is to set the url of nvim-cmp, like this: { "hrsh7th/nvim-cmp", url = "https://github.com/iguanacucumber/magazine.nvim.git" }, Gonna cc in @mehalter in case he has an opinion. |
I think I have a good solution for this. I've been also mulling over how to achieve this nicely. I'll give a recommendation on Monday |
2191331
to
4de5c80
Compare
@ALameLlama I revised the commit to set up Let me know what you think! |
📑 Description
Adds magazine.nvim, This replaces nvim-cmp and acts as a "beta" with performance and feature improvements before they get up streamed.